Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ECS with Laravel container #28

Merged
merged 1 commit into from
Jul 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code_analysis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:

-
name: 'Check Active Classes'
run: vendor/bin/easy-ci check-active-class src --ansi
run: vendor/bin/class-leak check src --ansi

name: ${{ matrix.actions.name }}
runs-on: ubuntu-latest
Expand Down
26 changes: 8 additions & 18 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,19 @@
"symplify/rule-doc-generator-contracts": "^11.1"
},
"require-dev": {
"symplify/easy-coding-standard": "^11.4",
"squizlabs/php_codesniffer": "^3.7.1",
"symplify/easy-coding-standard": "dev-main",
"squizlabs/php_codesniffer": "^3.7.2",
"phpunit/phpunit": "^10.2",
"symplify/rule-doc-generator": "^11.1",
"cweagans/composer-patches": "^1.7",
"php-parallel-lint/php-parallel-lint": "^1.3",
"phpstan/extension-installer": "^1.3",
"phpstan/phpstan": "^1.10.19",
"rector/rector": "^0.17.1",
"symplify/easy-ci": "^11.2",
"phpstan/phpstan": "^1.10.26",
"rector/rector": "^0.17.7",
"symplify/easy-ci": "^11.3",
"symplify/phpstan-extensions": "^11.2",
"tomasvotruba/unused-public": "^0.1.12",
"tomasvotruba/type-coverage": "^0.2.0"
"tomasvotruba/unused-public": "^0.1.14",
"tomasvotruba/type-coverage": "^0.2",
"tomasvotruba/class-leak": "0.0.22.72"
},
"autoload": {
"psr-4": {
Expand All @@ -33,17 +33,8 @@
"Symplify\\CodingStandard\\Tests\\": "tests"
}
},
"extra": {
"enable-patching": true,
"patches": {
"symfony/dependency-injection": [
"https://raw.githubusercontent.com/symplify/vendor-patch-files/main/patches/generic-php-config-loader.patch"
]
}
},
"config": {
"allow-plugins": {
"cweagans/composer-patches": true,
"phpstan/extension-installer": true
}
},
Expand All @@ -52,7 +43,6 @@
"fix-cs": "vendor/bin/ecs check --fix --ansi",
"phpstan": "vendor/bin/phpstan analyse --ansi --error-format symplify",
"rector": "vendor/bin/rector process --dry-run --ansi",
"release": "vendor/bin/monorepo-builder release patch --ansi",
"docs": "vendor/bin/rule-doc-generator generate src --output-file docs/rules_overview.md --ansi"
}
}
22 changes: 0 additions & 22 deletions config/config.php

This file was deleted.

5 changes: 1 addition & 4 deletions config/symplify.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?php

declare(strict_types=1);

use PhpCsFixer\Fixer\Phpdoc\GeneralPhpdocAnnotationRemoveFixer;
use Symplify\CodingStandard\Fixer\Annotation\RemovePHPStormAnnotationFixer;
use Symplify\CodingStandard\Fixer\ArrayNotation\ArrayListItemNewlineFixer;
Expand All @@ -15,10 +16,6 @@
use Symplify\EasyCodingStandard\Config\ECSConfig;

return static function (ECSConfig $ecsConfig): void {
$ecsConfig->import(__DIR__ . '/config.php');

// epxpclit like other configs :) no magic!!!

$ecsConfig->rules([
// docblocks and comments
RemovePHPStormAnnotationFixer::class,
Expand Down