Remove NewlineServiceDefinitionConfigFixer, as already handled by flu…

…ent newliner (#16)
symplify · Jan 30, 2023 · 96f6eda · 96f6eda
1 parent a52709d
commit 96f6eda
Show file tree

Hide file tree

Showing 10 changed files with 1 addition and 353 deletions.
diff --git a/config/symplify.php b/config/symplify.php
@@ -9,7 +9,6 @@
 use Symplify\CodingStandard\Fixer\Commenting\RemoveUselessDefaultCommentFixer;
 use Symplify\CodingStandard\Fixer\LineLength\LineLengthFixer;
 use Symplify\CodingStandard\Fixer\Spacing\MethodChainingNewlineFixer;
-use Symplify\CodingStandard\Fixer\Spacing\NewlineServiceDefinitionConfigFixer;
 use Symplify\CodingStandard\Fixer\Spacing\SpaceAfterCommaHereNowDocFixer;
 use Symplify\CodingStandard\Fixer\Spacing\StandaloneLinePromotedPropertyFixer;
 use Symplify\CodingStandard\Fixer\Strict\BlankLineAfterStrictTypesFixer;
@@ -33,7 +32,6 @@
 
         // newlines
         MethodChainingNewlineFixer::class,
-        NewlineServiceDefinitionConfigFixer::class,
         SpaceAfterCommaHereNowDocFixer::class,
         BlankLineAfterStrictTypesFixer::class,
 

diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 14 Rules Overview
+# 13 Rules Overview
 
 ## ArrayListItemNewlineFixer
 
@@ -136,26 +136,6 @@ Each chain method call must be on own line
 
 <br>
 
-## NewlineServiceDefinitionConfigFixer
-
-Add newline for a fluent call on service definition in Symfony config
-
-- class: [`Symplify\CodingStandard\Fixer\Spacing\NewlineServiceDefinitionConfigFixer`](../src/Fixer/Spacing/NewlineServiceDefinitionConfigFixer.php)
-
-```diff
- use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
- use Symplify\CodingStandard\Fixer\LineLength\LineLengthFixer;
-
- return static function (ContainerConfigurator $containerConfigurator): void {
-     $services = $containerConfigurator->services();
--    $services->set(LineLengthFixer::class)->call('configure', [['values']]);
-+    $services->set(LineLengthFixer::class)
-+        ->call('configure', [['values']]);
- };
-```
-
-<br>
-
 ## ParamReturnAndVarTagMalformsFixer
 
 Fixes @param, @return, `@var` and inline `@var` annotations broken formats

diff --git a/src/Fixer/Spacing/NewlineServiceDefinitionConfigFixer.php b/src/Fixer/Spacing/NewlineServiceDefinitionConfigFixer.php
diff --git a/src/TokenAnalyzer/SymfonyClosureAnalyzer.php b/src/TokenAnalyzer/SymfonyClosureAnalyzer.php
diff --git a/tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/Fixture/many_methods.php.inc b/tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/Fixture/many_methods.php.inc
diff --git a/...s/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/Fixture/skip_already_newlined.php.inc b/...s/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/Fixture/skip_already_newlined.php.inc
diff --git a/tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/Fixture/skip_not_config_call.php.inc b/tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/Fixture/skip_not_config_call.php.inc
diff --git a/tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/Fixture/wrong.php.inc b/tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/Fixture/wrong.php.inc
diff --git a/...r/Spacing/NewlineServiceDefinitionConfigFixer/NewlineServiceDefinitionConfigFixerTest.php b/...r/Spacing/NewlineServiceDefinitionConfigFixer/NewlineServiceDefinitionConfigFixerTest.php
diff --git a/tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/config/configured_rule.php b/tests/Fixer/Spacing/NewlineServiceDefinitionConfigFixer/config/configured_rule.php