Skip to content

Commit

Permalink
Remove NewlineServiceDefinitionConfigFixer, as already handled by flu…
Browse files Browse the repository at this point in the history
…ent newliner (#16)
  • Loading branch information
TomasVotruba authored Jan 30, 2023
1 parent a52709d commit 96f6eda
Show file tree
Hide file tree
Showing 10 changed files with 1 addition and 353 deletions.
2 changes: 0 additions & 2 deletions config/symplify.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
use Symplify\CodingStandard\Fixer\Commenting\RemoveUselessDefaultCommentFixer;
use Symplify\CodingStandard\Fixer\LineLength\LineLengthFixer;
use Symplify\CodingStandard\Fixer\Spacing\MethodChainingNewlineFixer;
use Symplify\CodingStandard\Fixer\Spacing\NewlineServiceDefinitionConfigFixer;
use Symplify\CodingStandard\Fixer\Spacing\SpaceAfterCommaHereNowDocFixer;
use Symplify\CodingStandard\Fixer\Spacing\StandaloneLinePromotedPropertyFixer;
use Symplify\CodingStandard\Fixer\Strict\BlankLineAfterStrictTypesFixer;
Expand All @@ -33,7 +32,6 @@

// newlines
MethodChainingNewlineFixer::class,
NewlineServiceDefinitionConfigFixer::class,
SpaceAfterCommaHereNowDocFixer::class,
BlankLineAfterStrictTypesFixer::class,

Expand Down
22 changes: 1 addition & 21 deletions docs/rules_overview.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# 14 Rules Overview
# 13 Rules Overview

## ArrayListItemNewlineFixer

Expand Down Expand Up @@ -136,26 +136,6 @@ Each chain method call must be on own line

<br>

## NewlineServiceDefinitionConfigFixer

Add newline for a fluent call on service definition in Symfony config

- class: [`Symplify\CodingStandard\Fixer\Spacing\NewlineServiceDefinitionConfigFixer`](../src/Fixer/Spacing/NewlineServiceDefinitionConfigFixer.php)

```diff
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symplify\CodingStandard\Fixer\LineLength\LineLengthFixer;

return static function (ContainerConfigurator $containerConfigurator): void {
$services = $containerConfigurator->services();
- $services->set(LineLengthFixer::class)->call('configure', [['values']]);
+ $services->set(LineLengthFixer::class)
+ ->call('configure', [['values']]);
};
```

<br>

## ParamReturnAndVarTagMalformsFixer

Fixes @param, @return, `@var` and inline `@var` annotations broken formats
Expand Down
170 changes: 0 additions & 170 deletions src/Fixer/Spacing/NewlineServiceDefinitionConfigFixer.php

This file was deleted.

47 changes: 0 additions & 47 deletions src/TokenAnalyzer/SymfonyClosureAnalyzer.php

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit 96f6eda

Please sign in to comment.