update content only if changed

symplify · Feb 23, 2024 · 1a591e1 · 1a591e1
1 parent eb8c151
commit 1a591e1
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/src/Fixer/Commenting/RemoveUselessDefaultCommentFixer.php b/src/Fixer/Commenting/RemoveUselessDefaultCommentFixer.php
@@ -63,12 +63,13 @@ public function fix(SplFileInfo $fileInfo, Tokens $tokens): void
                 continue;
             }
 
+            $originalContent = $token->getContent();
             $cleanedDocContent = $this->uselessDocBlockCleaner->clearDocTokenContent($token);
 
             if ($cleanedDocContent === '') {
                 // remove token
                 $tokens->clearTokenAndMergeSurroundingWhitespace($index);
-            } else {
+            } elseif ($cleanedDocContent !== $originalContent) {
                 // update in case of other contents
                 $tokens[$index] = new Token([T_DOC_COMMENT, $cleanedDocContent]);
             }

diff --git a/tests/Fixer/Commenting/RemoveUselessDefaultCommentFixer/Fixture/skip_no_changes.php.inc b/tests/Fixer/Commenting/RemoveUselessDefaultCommentFixer/Fixture/skip_no_changes.php.inc
@@ -0,0 +1,15 @@
+<?php
+
+namespace Symplify\CodingStandard\Tests\Fixer\Commenting\RemoveUselessDefaultCommentFixer\Fixture;
+
+final class SkipNoChanges
+{
+    public function run()
+    {
+        // some line
+        $someLine = 100;
+
+        // another line
+        $someLine = 100;
+    }
+}
diff --git a/tests/Fixer/Commenting/RemoveUselessDefaultCommentFixer/config/configured_rule.php b/tests/Fixer/Commenting/RemoveUselessDefaultCommentFixer/config/configured_rule.php
@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 use PhpCsFixer\Fixer\Basic\BracesFixer;
-
 use Symplify\CodingStandard\Fixer\Commenting\RemoveUselessDefaultCommentFixer;
 use Symplify\EasyCodingStandard\Config\ECSConfig;