Skip to content

[LiveComponent] Fix query string decoding with no = #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Jun 8, 2025

Q A
Bug fix? yes
New feature? no
Docs? no
Issues Fix #2826 (when released and a website update)
License MIT

The root cause of #2826 is in fact a bug in LiveComponent ... that i'm very surprised no one already experienced oO

In url_utils: fromQueryString missed a nullcheck. Triggering a TypeError.

?foo&bar=

@carsonbot carsonbot added Bug Bug Fix LiveComponent Status: Needs Review Needs to be reviewed labels Jun 8, 2025
Copy link
Contributor

github-actions bot commented Jun 8, 2025

📊 Packages dist files size difference

ℹ️ No difference in dist packagesFiles.

@smnandre
Copy link
Member Author

smnandre commented Jun 8, 2025

(failure fixed in #2830)

@smnandre smnandre requested a review from Kocal June 8, 2025 03:47
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jun 8, 2025
@Kocal Kocal force-pushed the fix/2826-live-from-query-string branch from a6ec29f to e53fc8b Compare June 8, 2025 13:04
@Kocal
Copy link
Member

Kocal commented Jun 8, 2025

Thank you @smnandre.

@Kocal Kocal merged commit c4de247 into symfony:2.x Jun 8, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix LiveComponent Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icons] Website's search seems to be broken
3 participants