[LiveComponent] Fix query string decoding with no =
#2829
Merged
+28
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Bug
📊 Packages dist files size differenceℹ️ No difference in dist packagesFiles. |
|
(failure fixed in #2830) |
Kocal
approved these changes
Jun 8, 2025
carsonbot
added
Status: Reviewed
Kocal
force-pushed
the
fix/2826-live-from-query-string
branch
from
a6ec29f to
e53fc8b
Compare
|
Thank you @smnandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of #2826 is in fact a bug in LiveComponent ... that i'm very surprised no one already experienced oO
In url_utils: fromQueryString missed a nullcheck. Triggering a TypeError.
?foo&bar=