[CI] Run unit and functional tests under Windows too #2816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
ci-tests-windows
branch
5 times, most recently
from
614dc69 to
67ce0d1
Compare
Kocal
force-pushed
the
ci-tests-windows
branch
3 times, most recently
from
72ef9f3 to
6921cfd
Compare
Kocal
force-pushed
the
ci-tests-windows
branch
16 times, most recently
from
1c13a15 to
b350423
Compare
|
Tests for the following UX Packages are failing: LiveComponent React Svelte Toolkit Vue I'm planning to fix tests for Toolkit, React, Svelte, and Vue in another PRs. |
This was referenced Jul 1, 2025
Kocal
added a commit
that referenced
this pull request
Jul 6, 2025
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Toolkit] Fix comptability with Windows | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Following #2816 Commits ------- 98aba7a [Toolkit] Fix comptability with Windows
Kocal
added a commit
that referenced
this pull request
Jul 6, 2025
…indows server (Kocal) This PR was merged into the 2.x branch. Discussion ---------- [Vue][React][Svelte] Fix components assets compilation on Windows server | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Following #2816, this PR fixes the `controller.js` files generation when the Symfony app is running on Windows server: ``` Testing F... 4 / 4 (100%) Time: 00:01.229, Memory: 30.00 MB There was 1 failure: 1) Symfony\UX\Vue\Tests\AssetMapper\VueControllerLoaderAssetCompilerTest::testCompileDynamicallyAddsContents Failed asserting that 'import component_0 from '../../vue/controllers/MyVueController.js';\n import component_1 from '../../vue/controllers/subdir/DeeperVueController.js';\n export const components = {"MyVueController": component_0, "subdir\DeeperVueController": component_1};' contains ""subdir/DeeperVueController": component_". D:\a\ux\ux\src\Vue\tests\AssetMapper\VueControllerLoaderAssetCompilerTest.php:72 ``` I was able to set-up a Windows VM to ensure the PR fixes the problem (tip: don't use a remote VM in a train... 🙂) Before, you can see that `subfolder\Goodbye` is interpreted as `subfolderGoodbye`, meaning that is not possible to use `subfolder/Goodbye` Vue component (I made a typo in the Twig template, but it has no effect): <img width="1704" alt="Capture d’écran 2025-07-02 à 09 39 00" src="https://github.com/user-attachments/assets/7b812dfb-cb45-46c3-9ec6-50a691e3e38f" /> With the patch, the path now contains `/` instead of `\`, the component `subfolder/Goodbye` is now usable: <img width="1704" alt="Capture d’écran 2025-07-02 à 09 58 07" src="https://github.com/user-attachments/assets/3a1195f1-c84b-4c42-9bd1-21fb2b9d66a7" /> Commits ------- ac9e9b5 [Vue][React][Svelte] Fix controllers assets compilation on Windows server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a must have, especially for Toolkit which deals a lot with paths