Skip to content

[Map] Add option to configure attribution and zoom control #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented May 29, 2025

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues Fix #...
License MIT

Add option to configure attribution and zoom control for leaflet

@dannyvw dannyvw requested a review from Kocal as a code owner May 29, 2025 09:54
@carsonbot carsonbot added Feature New Feature Map Status: Needs Review Needs to be reviewed labels May 29, 2025
@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

Copy link
Contributor

github-actions bot commented May 29, 2025

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Map (Bridge Leaflet)
map_controller.d.ts 2.04 kB / 672 B 2.26 kB+11% 📈 / 715 B+6% 📈
map_controller.js 9.71 kB / 2.59 kB 10.28 kB+6% 📈 / 2.68 kB+3% 📈

@dannyvw dannyvw force-pushed the leaflet-options branch 5 times, most recently from 2cb5af4 to a6f6b06 Compare May 30, 2025 10:02
@dannyvw dannyvw changed the title [Map] Add option to configure attribution and zoom control position [Map] Add option to configure attribution and zoom control May 30, 2025
@dannyvw dannyvw force-pushed the leaflet-options branch 3 times, most recently from d3a0001 to 7df41ba Compare June 2, 2025 06:00
@dannyvw
Copy link
Contributor Author

dannyvw commented Jun 5, 2025

@Kocal Do you perhaps have time to check this?

@Kocal
Copy link
Member

Kocal commented Jun 5, 2025

This week-end :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Map Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants