Show a visible link to the docs of each package #2309
+66
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll open a PR this week-end (ideally sunday afternoon) -- probably loosely based on the stimulus bundle page "menu", with some simplification in markup + CSS, and some things to help us bring the next chapter :) But I see no problem to make this change in the meantime! Do you think we could keep the current (flat) icon, with the color theme of the package ? |
|
@javiereguiluz I'm on it and pretty confident i'll open the PR soon... (@kbond can confirm if needed) But depending on tonight, i may miss the deadline by a day or two... Poke me if you want to have an "avant-première" ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that you mentioned that there's a work-in-progress effort to update some things in the current design (#2273 (comment)) but I think we should fix this issue quickly because it's a problem in many long package pages.
If you don't like the proposed changes here it's fine; let's iterate over them. Tell me what to fix or change and I'll do it. Thanks!
This is how this PR looks at the moment: