Migrate to static data providers using rector/rector

symfony · Feb 14, 2023 · 5e325f3 · 5e325f3
1 parent 505c736
commit 5e325f3
Show file tree

Hide file tree

Showing 16 changed files with 27 additions and 27 deletions.
diff --git a/Tests/Annotation/ContextTest.php b/Tests/Annotation/ContextTest.php
@@ -51,7 +51,7 @@ public function testThrowsOnEmptyContextLegacy(callable $factory)
         $factory();
     }
 
-    public function provideTestThrowsOnEmptyContextLegacyData(): iterable
+    public static function provideTestThrowsOnEmptyContextLegacyData(): iterable
     {
         yield 'doctrine-style: value option as empty array' => [function () { new Context(['value' => []]); }];
         yield 'doctrine-style: context option as empty array' => [function () { new Context(['context' => []]); }];
@@ -70,7 +70,7 @@ public function testThrowsOnNonArrayContext(array $options)
         new Context($options);
     }
 
-    public function provideTestThrowsOnNonArrayContextData(): iterable
+    public static function provideTestThrowsOnNonArrayContextData(): iterable
     {
         yield 'non-array context' => [['context' => 'not_an_array']];
         yield 'non-array normalization context' => [['normalizationContext' => 'not_an_array']];
@@ -136,7 +136,7 @@ public function testValidInputs(callable $factory, string $expectedDump)
         $this->assertDumpEquals($expectedDump, $factory());
     }
 
-    public function provideValidInputs(): iterable
+    public static function provideValidInputs(): iterable
     {
         yield 'named arguments: with context option' => [
             function () { return new Context(...['context' => ['foo' => 'bar']]); },
@@ -224,7 +224,7 @@ public function testValidLegacyInputs(callable $factory, string $expectedDump)
         $this->assertDumpEquals($expectedDump, $factory());
     }
 
-    public function provideValidLegacyInputs(): iterable
+    public static function provideValidLegacyInputs(): iterable
     {
         yield 'doctrine-style: with context option' => [
             function () { return new Context(['context' => ['foo' => 'bar']]); },

diff --git a/Tests/Annotation/MaxDepthTest.php b/Tests/Annotation/MaxDepthTest.php
@@ -33,7 +33,7 @@ public function testNotSetMaxDepthParameter()
         new MaxDepth([]);
     }
 
-    public function provideInvalidValues()
+    public static function provideInvalidValues()
     {
         return [
             [''],

diff --git a/Tests/Annotation/SerializedNameTest.php b/Tests/Annotation/SerializedNameTest.php
@@ -33,7 +33,7 @@ public function testNotSetSerializedNameParameter()
         new SerializedName([]);
     }
 
-    public function provideInvalidValues(): array
+    public static function provideInvalidValues(): array
     {
         return [
             [''],

diff --git a/Tests/DeserializeNestedArrayOfObjectsTest.php b/Tests/DeserializeNestedArrayOfObjectsTest.php
@@ -20,7 +20,7 @@
 
 class DeserializeNestedArrayOfObjectsTest extends TestCase
 {
-    public function provider()
+    public static function provider()
     {
         return [
             // from property PhpDoc

diff --git a/Tests/Encoder/JsonDecodeTest.php b/Tests/Encoder/JsonDecodeTest.php
@@ -43,7 +43,7 @@ public function testDecode($toDecode, $expected, $context)
         );
     }
 
-    public function decodeProvider()
+    public static function decodeProvider()
     {
         $stdClass = new \stdClass();
         $stdClass->foo = 'bar';
@@ -65,7 +65,7 @@ public function testDecodeWithException($value)
         $this->decode->decode($value, JsonEncoder::FORMAT);
     }
 
-    public function decodeProviderException()
+    public static function decodeProviderException()
     {
         return [
             ["{'foo': 'bar'}"],

diff --git a/Tests/Encoder/JsonEncodeTest.php b/Tests/Encoder/JsonEncodeTest.php
@@ -42,7 +42,7 @@ public function testEncode($toEncode, $expected, $context)
         );
     }
 
-    public function encodeProvider()
+    public static function encodeProvider()
     {
         return [
             [[], '[]', []],

diff --git a/Tests/Mapping/Factory/CompiledClassMetadataFactoryTest.php b/Tests/Mapping/Factory/CompiledClassMetadataFactoryTest.php
@@ -128,7 +128,7 @@ public function testItDelegatesHasMetadataForCall()
         $this->assertTrue($compiledClassMetadataFactory->hasMetadataFor(SerializedNameDummy::class));
     }
 
-    public function valueProvider()
+    public static function valueProvider()
     {
         return [
             [Dummy::class],

diff --git a/Tests/NameConverter/CamelCaseToSnakeCaseNameConverterTest.php b/Tests/NameConverter/CamelCaseToSnakeCaseNameConverterTest.php
@@ -44,7 +44,7 @@ public function testDenormalize($underscored, $camelCased, $useLowerCamelCase)
         $this->assertEquals($nameConverter->denormalize($underscored), $camelCased);
     }
 
-    public function attributeProvider()
+    public static function attributeProvider()
     {
         return [
             ['coop_tilleuls', 'coopTilleuls', true],

diff --git a/Tests/NameConverter/MetadataAwareNameConverterTest.php b/Tests/NameConverter/MetadataAwareNameConverterTest.php
@@ -97,7 +97,7 @@ public function testDenormalizeWithFallback($expected, $propertyName)
         $this->assertEquals($expected, $nameConverter->denormalize($propertyName, SerializedNameDummy::class));
     }
 
-    public function attributeProvider(): array
+    public static function attributeProvider(): array
     {
         return [
             ['foo', 'baz'],
@@ -107,7 +107,7 @@ public function attributeProvider(): array
         ];
     }
 
-    public function fallbackAttributeProvider(): array
+    public static function fallbackAttributeProvider(): array
     {
         return [
             ['foo', 'baz'],
@@ -141,7 +141,7 @@ public function testDenormalizeWithGroups($expected, $propertyName, $context = [
         $this->assertEquals($expected, $nameConverter->denormalize($propertyName, OtherSerializedNameDummy::class, null, $context));
     }
 
-    public function attributeAndContextProvider()
+    public static function attributeAndContextProvider()
     {
         return [
             ['buz', 'buz', ['groups' => ['a']]],

diff --git a/Tests/Normalizer/AbstractNormalizerTest.php b/Tests/Normalizer/AbstractNormalizerTest.php
@@ -201,7 +201,7 @@ public function testObjectWithVariadicConstructorTypedArguments(AbstractNormaliz
         }
     }
 
-    public function getNormalizer()
+    public static function getNormalizer()
     {
         $extractor = new PhpDocExtractor();
 

diff --git a/Tests/Normalizer/ConstraintViolationListNormalizerTest.php b/Tests/Normalizer/ConstraintViolationListNormalizerTest.php
@@ -128,7 +128,7 @@ public function testNormalizePayloadFields($fields, array $expected = null)
         $this->assertSame($expected, $violation['payload']);
     }
 
-    public function payloadFieldsProvider(): iterable
+    public static function payloadFieldsProvider(): iterable
     {
         yield [['severity', 'anotherField1'], ['severity' => 'warning']];
         yield [null, ['severity' => 'warning', 'anotherField2' => 'aValue']];

diff --git a/Tests/Normalizer/DataUriNormalizerTest.php b/Tests/Normalizer/DataUriNormalizerTest.php
@@ -130,7 +130,7 @@ public function testInvalidData($uri)
         $this->normalizer->denormalize($uri, 'SplFileObject');
     }
 
-    public function invalidUriProvider()
+    public static function invalidUriProvider()
     {
         return [
             ['dataxbase64'],
@@ -156,7 +156,7 @@ public function testValidData($uri)
         $this->assertInstanceOf(\SplFileObject::class, $this->normalizer->denormalize($uri, 'SplFileObject'));
     }
 
-    public function validUriProvider()
+    public static function validUriProvider()
     {
         return [
             ['data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQAQMAAAAlPW0iAAAABlBMVEUAAAD///+l2Z/dAAAAM0lEQVR4nGP4/5/h/1+G/58ZDrAz3D/McH8yw83NDDeNGe4Ug9C9zwz3gVLMDA/A6P9/AFGGFyjOXZtQAAAAAElFTkSuQmCC'],

diff --git a/Tests/Normalizer/DateIntervalNormalizerTest.php b/Tests/Normalizer/DateIntervalNormalizerTest.php
@@ -31,7 +31,7 @@ protected function setUp(): void
         $this->normalizer = new DateIntervalNormalizer();
     }
 
-    public function dataProviderISO()
+    public static function dataProviderISO()
     {
         $data = [
             ['P%YY%MM%DDT%HH%IM%SS', 'P00Y00M00DT00H00M00S', 'PT0S'],

diff --git a/Tests/Normalizer/DateTimeNormalizerTest.php b/Tests/Normalizer/DateTimeNormalizerTest.php
@@ -73,7 +73,7 @@ public function testNormalizeUsingTimeZonePassedInContext($expected, $input, $ti
         ]));
     }
 
-    public function normalizeUsingTimeZonePassedInContextProvider()
+    public static function normalizeUsingTimeZonePassedInContextProvider()
     {
         yield ['2016-12-01T00:00:00+00:00', new \DateTime('2016/12/01', new \DateTimeZone('UTC')), null];
         yield ['2016-12-01T00:00:00+09:00', new \DateTime('2016/12/01', new \DateTimeZone('Japan')), new \DateTimeZone('Japan')];
@@ -99,7 +99,7 @@ public function testNormalizeUsingTimeZonePassedInContextAndFormattedWithMicrose
         );
     }
 
-    public function normalizeUsingTimeZonePassedInContextAndExpectedFormatWithMicrosecondsProvider()
+    public static function normalizeUsingTimeZonePassedInContextAndExpectedFormatWithMicrosecondsProvider()
     {
         yield [
             '2018-12-01T18:03:06.067634',
@@ -211,7 +211,7 @@ public function testDenormalizeUsingTimezonePassedInContext($input, $expected, $
         $this->assertEquals($expected, $actual);
     }
 
-    public function denormalizeUsingTimezonePassedInContextProvider()
+    public static function denormalizeUsingTimezonePassedInContextProvider()
     {
         yield 'with timezone' => [
             '2016/12/01 17:35:00',

diff --git a/Tests/Normalizer/UidNormalizerTest.php b/Tests/Normalizer/UidNormalizerTest.php
@@ -46,7 +46,7 @@ public function testSupportsNormalization()
         $this->assertFalse($this->normalizer->supportsNormalization(new \stdClass()));
     }
 
-    public function normalizeProvider()
+    public static function normalizeProvider()
     {
         $uidFormats = [null, 'canonical', 'base58', 'base32', 'rfc4122'];
         $data = [
@@ -117,7 +117,7 @@ public function testNormalize(string $expected, AbstractUid $uid, ?string $uidFo
         ] : []));
     }
 
-    public function dataProvider()
+    public static function dataProvider()
     {
         return [
             ['9b7541de-6f87-11ea-ab3c-9da9a81562fc', UuidV1::class],

diff --git a/Tests/SerializerTest.php b/Tests/SerializerTest.php
@@ -550,7 +550,7 @@ public function testNormalizeTransformEmptyArrayObjectToArray()
         $this->assertSame('{"foo":[],"bar":["notempty"],"baz":{"nested":[]},"a":{"nested":[]},"b":[]}', $serializer->serialize($object, 'json'));
     }
 
-    public function provideObjectOrCollectionTests()
+    public static function provideObjectOrCollectionTests()
     {
         $serializer = new Serializer(
             [
@@ -1238,7 +1238,7 @@ public function testNoCollectDenormalizationErrorsWithWrongEnum()
         }
     }
 
-    public function provideCollectDenormalizationErrors()
+    public static function provideCollectDenormalizationErrors()
     {
         return [
             [null],
-Original file line number
+Diff line change
@@ Expand Up @@
             }
         }
-        public function getNormalizer()
+        public static function getNormalizer()
         {
             $extractor = new PhpDocExtractor();
@@ Expand Down @@