New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native types where possible #118

Merged

derrabus merged 1 commit into symfony:main from derrabus:improvement/types

Jul 25, 2023

Member

derrabus commented Jul 25, 2023

This PR improves the typing throughout the codebase:

Native types are added where possible without a BC break
PHPDoc@return annotations have been added to prevent deprecations triggered by ErrorHandler
More PHPDoc has been added where a native type cannot be set as long as we support PHP 7.2.
PHPUnit data providers have been declared static.


          Add native types where possible

4fd4323

Member Author

derrabus commented Jul 25, 2023

fabbot error is unrelated

derrabus requested a review from nicolas-grekas

July 25, 2023 08:38

nicolas-grekas approved these changes

View reviewed changes

derrabus merged commit 18c9e82 into symfony:main

6 checks passed

derrabus deleted the improvement/types branch

July 25, 2023 09:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet