Leverage Request::getPayload() to populate the parsed body of PSR-7 requests

[AurelienPillevesse]

I'm trying to send a POST request with the fields below and application/x-www-form-urlencoded header :

• "city": "Paris"
• "country": "France"

If I send it like that, the fields are understood and I have these fields when I display the Request :

• [ "city": "Paris", "country": "France" ]

Now if I send the same POST request with application/json header (with the same fields but in JSON format) :

• {"city":"Paris","country":"France"}

They are not understand and I have an empty Request :

• []

[derrabus]

Thank you for your PR.

First of all "it works"/"it doesn't work" does not tell me what exactly "it" is that you want to be working. Please adjust the PR description, so the reader knows what exactly the feature is that you'd like to deliver here.

Secondly, we don't merge new features without any tests. That's a blocker.

[derrabus]

Thank you. I think, we're almost there. 🙂

Leveraging the new getPayload() method to populate the parsed body of the PSR-7 request is a good idea.

The test that you've added covers the happy case well. But what happens if the JSON payload cannot be decoded? We should also have a test that covers this case.

[AurelienPillevesse]

That's a good idea, I will add this test case tomorrow morning

[AurelienPillevesse]

New tests have been added

[derrabus]

Looks good, thank you!

[derrabus]

Thank you @AurelienPillevesse.

[andreladocruz]

getting error after updating to 2.3

Symfony\Component\HttpFoundation\Request::getPayload(): Return value must be of type Symfony\Component\HttpFoundation\InputBag, Symfony\Component\HttpFoundation\ParameterBag returned

[derrabus]

Please report this to the symfony/symfony repo.

[WebHaZe]

getting error

TypeError: Symfony\Component\HttpFoundation\Request::getPayload(): Return value must be of type Symfony\Component\HttpFoundation\InputBag, Symfony\Component\HttpFoundation\ParameterBag returned in /var/www/vendor/symfony/http-foundation/Request.php:1517

It is unexpected critical issue in my project from yesterday. Please pay attention to it as fast as it possible.

[OskarStark]

As @derrabus mentioned, please open a ticket on symfony/symfony.

In the meantime, you can also provide a PR to fix the issue yourself or pin the 2.2.0 version from before

[derrabus]

Laravel people, this way: laravel/framework#47834

[derrabus]

Please pay attention to it as fast as it possible.

Please don't boss people around.

I'm locking the PR now because I don't think we need more stack traces for the same Laravel issue.