[PHP 8.5] Add array_first and array_last
#525
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
May 8, 2025
TimWolla
approved these changes
May 9, 2025
|
I'm afraid that the current var_dump(array_slice(['a' => 2, 'b' => 1], -1, 1)[0]);outputs a warning telling |
|
I guess array_key_last should be used then |
|
@nicolas-grekas is it OK to bump the minimum PHP version to 7.3? If we have array_key_first/last, it would make this much more cleaner. |
|
Ah right, then current(array_slice()) should do it |
Adds polyfills for the PHP 8.5's `array_first` and `array_last` functions. The polyfills would have been a bit cleaner if we used the `array_key_first` and `array_key_last` functions, but they were added in PHP 7.3, and are not available on PHP 7.2. This adds the same tests from php-src patch. - [RFC: `array_first()` and `array_last()`](https://wiki.php.net/rfc/array_first_last) - [php-src commit](php/php-src@168343d) - [PHP.Watch polyfill for PHP 8.0+](https://php.watch/versions/8.5/array_first-array_last) Co-authored-by: Nicolas Grekas <[email protected]>
|
Updated with |
TimWolla
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds polyfills for the PHP 8.5's
array_firstandarray_lastfunctions.The polyfills would have been a bit cleaner if we used the
array_key_firstandarray_key_lastfunctions, but they were added in PHP 7.3, and are not available on PHP 7.2.This adds the same tests from php-src patch.
array_first()andarray_last()