[WIP] improvements to use it #1
Conversation
|
@dbu that is it. |
|
|
||
| .PHONY: test docs |
There was a problem hiding this comment.
this should stay in: https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
There was a problem hiding this comment.
we do not have docs to test in our bundles/components.
There was a problem hiding this comment.
yeah, but unless i missed something, you completely removed .PHONY. this should list all meta targets that are not files (which is every target for us, as we are not compiling code with the makefile)
do a touch test && make test on the commandline to see the effect of having or not having phony.
project/src/Resources/meta/LICENSE
Outdated
| @@ -0,0 +1,23 @@ | |||
| SeoBundle | |||
There was a problem hiding this comment.
this should be a placeholder or the line be deleted.
| const GITHUB_EMAIL = '[email protected]'; | ||
| const PACKAGIST_GROUP = 'sonata-project'; | ||
| const GITHUB_GROUP = 'symfony-cmf'; | ||
| const GITHUB_USER = 'electricmaxxx'; |
There was a problem hiding this comment.
would we have to create a specific user for the dev-kit?
There was a problem hiding this comment.
Yes, and i would like to put those parameters in a .env (with a checked in .env.dist to keep this application reusable and maybe push something back to sonata.
…figured php version
| } | ||
|
|
||
| $branchConfig = $projectConfig['branches'][$currentBranch]; | ||
| $composerAsJson['require']['php'] = $this->evaluateVersionString($branchConfig['php']); |
There was a problem hiding this comment.
@dbu i crate php version constraint, and the symfony version constraints in here.
| $this->evaluateVersionString($branchConfig['versions']['symfony']), | ||
| '^2.8 | ' | ||
| ); | ||
| } elseif (preg_match('/symfony\//', $package) && 'friendsofsymfony/jsrouting-bundle' !== $package) { |
There was a problem hiding this comment.
@dbu you are better in regex, right? can you give me an regex not to exclude friendsofsymfony/ that ugly way. I should be something that starts with symfony/
There was a problem hiding this comment.
this is working with the parsed json, right? then you could do preg_match('/^symfony\//', $package). the caret symbol at the beginning of the expression matches the beginning of the subject.
Support for PHP >= 5.6 for symfony-cmf/testing
This are the first improvements to use it in cmf and to which leads to first dispatch: symfony-cmf/seo-bundle#339