[Windows] Add support for php.new (herd-lite) #26
Conversation
I wrote some directions in the main repo to do so: https://github.com/symfony-cli/symfony-cli/blob/main/CONTRIBUTING.md#additional-repositories |
| @@ -51,6 +51,11 @@ func (s *PHPStore) doDiscover() { | |||
| if userHomeDir != "" { | |||
| s.discoverFromDir(filepath.Join(userHomeDir, ".config", "herd", "bin"), nil, regexp.MustCompile("^php\\d{2}$"), "Herd") | |||
| } | |||
|
|
|||
| // Herd-lite | |||
| if userHomeDir != "" { | |||
There was a problem hiding this comment.
what about merging it with the previous if userHomeDir != "" ?
|
|
||
| // Herd-lite | ||
| if userHomeDir != "" { | ||
| s.addFromDir(filepath.Join(userHomeDir, ".config", "herd-lite", "bin"), nil, "Herd-lite") |
There was a problem hiding this comment.
| s.addFromDir(filepath.Join(userHomeDir, ".config", "herd-lite", "bin"), nil, "Herd-lite") | |
| s.addFromDir(filepath.Join(userHomeDir, ".config", "herd-lite", "bin"), nil, "php.new (Herd-lite)") |
?
Totally, given the installation files, PHP should be available at |
Great 👍 |
I suppose it works, but I haven't been able to test it.
With Go, how can I use my PR with the Symfony CLI, so I can try to see if
local:php:listgives me PHP from herd-lite directory?Close #25