-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent screen from overlapping with the panels #20
Conversation
Kudos on your first PR for symbl @AsianCat54x |
Thanks! If you want, then I could just simply record and show the changes I have made. |
Hey @AsianCat54x , congrats on your PR. 👍 |
Thanks! Here is a comparison: Before (Case 1) simplescreenrecorder-2021-10-14-122423_DYGUx31w_DpxR.mp4After (Case 2) simplescreenrecorder-2021-10-14-122817_rAAVinaa_f98m.mp4As you can see, in case 1, the left part of the window that was being shared got cut off. On resizing the window, the shared screen move more left, so the greater part of the screen gets cut off. whereas, in case 2, the left part of the window is visible and even on resizing, it is still visible. Moreover, You would see that on resizing the window the shared screen's height gets smaller, it is just so that it maintains aspect ration. If you think that the height should not be changed, then I can fix that. |
@AsianCat54x I have checked your changes by testing them on my PC, looks good. |
Thanks @sbalikondwar! |
Kudos, SonarCloud Quality Gate passed! |
Is there something missing that needs to be done before getting this merged? |
This PR fixes issue #16