Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent screen from overlapping with the panels #20

Merged
merged 3 commits into from Oct 21, 2021
Merged

Prevent screen from overlapping with the panels #20

merged 3 commits into from Oct 21, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 12, 2021

This PR fixes issue #16

@sbalikondwar
Copy link
Contributor

Kudos on your first PR for symbl @AsianCat54x
I or someone will look at the changes and test them if they work

@ghost
Copy link
Author

ghost commented Oct 13, 2021

Thanks!

If you want, then I could just simply record and show the changes I have made.

@Akankshabhasin
Copy link
Contributor

Hey @AsianCat54x , congrats on your PR. 👍
Sure, feel free to share a screenshot/record a file to show the changes.

@ghost
Copy link
Author

ghost commented Oct 14, 2021

Thanks!

Here is a comparison:

Before (Case 1)

simplescreenrecorder-2021-10-14-122423_DYGUx31w_DpxR.mp4

After (Case 2)

simplescreenrecorder-2021-10-14-122817_rAAVinaa_f98m.mp4

As you can see, in case 1, the left part of the window that was being shared got cut off. On resizing the window, the shared screen move more left, so the greater part of the screen gets cut off.

whereas, in case 2, the left part of the window is visible and even on resizing, it is still visible.

Moreover, You would see that on resizing the window the shared screen's height gets smaller, it is just so that it maintains aspect ration.

If you think that the height should not be changed, then I can fix that.

@sbalikondwar
Copy link
Contributor

sbalikondwar commented Oct 14, 2021

@AsianCat54x I have checked your changes by testing them on my PC, looks good.

@sbalikondwar sbalikondwar self-requested a review October 14, 2021 18:42
@ghost
Copy link
Author

ghost commented Oct 15, 2021

Thanks @sbalikondwar!

@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ghost
Copy link
Author

ghost commented Oct 21, 2021

Is there something missing that needs to be done before getting this merged?

@sbalikondwar sbalikondwar merged commit 41121c2 into symblai:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants