Implement ArrayAccess #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves symbiote#45. Note that this is meant for the older version 3 of this module. I didn't start from the master branch because I still have SilverStripe 3 so I wouln't be able to test with SS4. But I guess this can be easily adapted to the newer version.
|
I think adding new interfaces is generally considered as a breaking API change, so I'm not sure we'll be able to introduce this into the SilverStripe 3 release line which is currently in security fix and critical bugfix only mode. Thank you for your contribution though! Feel free to reopen if you'd like to make this change for SIlverStripe 4 instead =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #45. Note that this is meant for the older version 3 of this module. I didn't start from the master branch because I still have SilverStripe 3 so I wouln't be able to test with SS4. But I guess this can be easily adapted to the newer version.