fix(AdvancedWorkflowExtension) Reload edited record #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by the executed workflow process
emteknetnz
requested changes
Apr 7, 2021
There was a problem hiding this comment.
Looks good, though a couple of questsions:
a) Would it be worth using Form::MERGE_AS_INTERNAL_VALUE as the merge strategy. I've noticed that it's used by Form::restoreFormState() so possibly it's more appropriate (I'm not familiar with the difference between the two though)
b) I've noticed that AdvancedWorkflowExtension::updateItemEditForm() also may have this same issue - would it be worth fixing this at the same time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workflow can sometimes modify the underlying record being shown to the user. The object reference that the form holds onto is different than the reference that the edit action operates on, meaning any change is not reflected back on the UI when users trigger a workflow action.