-
Notifications
You must be signed in to change notification settings - Fork 0
test: add integrated test for cli #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Coverage Report
File Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- package.json: Language not supported
- pnpm-lock.yaml: Language not supported
- tests/fixtures/build-script/package.json: Language not supported
- tests/fixtures/test-script/package.json: Language not supported
Comments suppressed due to low confidence (2)
tests/utils/cli.ts:120
- Converting runPubmCli from an async to a synchronous function may introduce timing issues if callers rely on awaiting subprocess completion; ensure that the subprocess exit is awaited or that tests are updated accordingly.
export function runPubmCli(
src/tasks/runner.ts:38
- The revised logic for determining npmOnly is stricter than before and may not account for mixed registry configurations; please confirm that this behavior is intentional.
npmOnly: options.registries.every((registry) => registry === 'npm'),
|
||
let distTags: string[] = []; | ||
|
||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silently catching errors during distTags retrieval might suppress important error information; consider logging the error or handling it in a way that aids future debugging.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's reasonable. I'm not going to make an error, but I'm going to make a warning.
No description provided.