Skip to content

test: add integrated test for cli #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

syi0808
Copy link
Owner

@syi0808 syi0808 commented Oct 23, 2024

No description provided.

@syi0808 syi0808 self-assigned this Oct 23, 2024
Copy link

github-actions bot commented Oct 23, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0% 0 / 2240
🔵 Statements 0% 0 / 2240
🔵 Functions 23.33% 7 / 30
🔵 Branches 23.33% 7 / 30
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/cli.ts 0% 0% 0% 0% 1-221
src/options.ts 0% 100% 100% 0% 3-15
src/tasks/required-missing-information.ts 0% 0% 0% 0% 1-114
src/tasks/runner.ts 0% 0% 0% 0% 1-246
Generated in workflow #141 for commit d1c1a6a by the Vitest Coverage Report Action

@syi0808 syi0808 requested a review from Copilot April 7, 2025 04:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.

Files not reviewed (4)
  • package.json: Language not supported
  • pnpm-lock.yaml: Language not supported
  • tests/fixtures/build-script/package.json: Language not supported
  • tests/fixtures/test-script/package.json: Language not supported
Comments suppressed due to low confidence (2)

tests/utils/cli.ts:120

  • Converting runPubmCli from an async to a synchronous function may introduce timing issues if callers rely on awaiting subprocess completion; ensure that the subprocess exit is awaited or that tests are updated accordingly.
export function runPubmCli(

src/tasks/runner.ts:38

  • The revised logic for determining npmOnly is stricter than before and may not account for mixed registry configurations; please confirm that this behavior is intentional.
npmOnly: options.registries.every((registry) => registry === 'npm'),


let distTags: string[] = [];

try {
Copy link
Preview

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silently catching errors during distTags retrieval might suppress important error information; consider logging the error or handling it in a way that aids future debugging.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's reasonable. I'm not going to make an error, but I'm going to make a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant