Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBH pipeline: store target params, continue from evolution data #6445

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Jan 20, 2025

Proposed changes

This enables PBJ by allowing to start from evolution data. To make sure all the parameters are consistent between the stopped and the continued evolution, the target parameters (like mass ratio and spins) are stored in input files and used to compute things like constraint damping parameters. The target parameters are also used in ID control and ecc-control.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Jan 20, 2025
@nilsvu
Copy link
Member Author

nilsvu commented Jan 20, 2025

@iago-mendes this PR promotes target params for ID control and ecc-control to input file metadata, could you check that I didn't break anything in the control loop?

@nilsvu nilsvu requested a review from knelli2 January 20, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant