Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CCE ability to read metric worldtube data #6444

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Jan 17, 2025

Proposed changes

The CCE executable now only accepts worldtube data in the Bondi-modal format. Other formats should be converted into the Bondi-modal format with the PreprocessCceWorldtube executable.

Upgrade instructions

The CCE and KleinGordon CCE executables can no longer read worldtube data written in the "metric" form (i.e. spatial metric, lapse, shift, and their time and radial derivatives). They can only now read worldtube data written in the bondi form, made up of modal coefficients. The preferred method for converting worldtube data is to use the PreprocessCceWorldtube executable.

The input file options H5IsBondiData and FixSpecNormalization are removed from the CCE and KleinGordon CCE input files.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 requested a review from nilsdeppe January 17, 2025 23:48
@knelli2 knelli2 force-pushed the drop_cce_metric_reader branch from 805ec16 to 6893c22 Compare January 18, 2025 03:38
@knelli2 knelli2 force-pushed the drop_cce_metric_reader branch from 6893c22 to 8af65a9 Compare January 18, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant