Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow atmosphere on reconstructed state, remove RelEuler system #6440

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Allow atmosphere on reconstructed state, remove RelEuler system #6440

merged 4 commits into from
Jan 22, 2025

Conversation

nilsdeppe
Copy link
Member

@nilsdeppe nilsdeppe commented Jan 16, 2025 •
edited
Loading

Proposed changes

Depends on:

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe added the dependent Needs a different PR to be merged in first label Jan 16, 2025
@nilsdeppe nilsdeppe requested a review from kidder January 16, 2025 15:29
kidder
kidder requested changes Jan 21, 2025
View reviewed changes
src/Evolution/DiscontinuousGalerkin/TimeDerivativeDecisions.hpp Outdated
/*!
* \brief Runtime control over time derivative work done.
*
* - `skip_flux_divergence_calculation` if `true` then we assume the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this parameter?

@nilsdeppe
Copy link
Member Author

Squashed and rebased. Thanks for the review!

@nilsdeppe
Add enum VariableFixing::FixReconstructedStateToAtmosphere
58f9192 
This will be used to control if we apply atmosphere to reconstructed states.
@nilsdeppe
Support FixToAtmosphere after reconstruction
b644155
@nilsdeppe
Add TimeDerivativeDecisions struct
248b865
@nilsdeppe
Remove Valencia system
1ef93f2 
We have optimizations in GRMHD to handle the zero magnetic field case reasonably
well.
@nilsdeppe
Copy link
Member Author

Rebased now that the other PR is merged

@nilsdeppe nilsdeppe merged commit 52390c3 into sxs-collaboration:develop Jan 22, 2025
21 of 24 checks passed
@knelli2 knelli2 removed the dependent Needs a different PR to be merged in first label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kidder kidder kidder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilsdeppe @kidder @knelli2