Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute ADM momenta as volume integrals #6433

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

iago-mendes
Copy link
Member

Proposed changes

This PR improves the accuracy of P_ADM and J_ADM by computing them as a sum of infinite volume integrals and finite surface integrals, which were derived from the standard ADM equations using Gauss' Law. We have attempted to use this same trick for other asymptotic quantities (ADM mass/energy and center of mass), but the volume version didn't improve accuracy. This is evident from the convergence plot below, in which the CoM volume results have been omitted because of blow-ups.

resolution_convergence_with_Jadm

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@iago-mendes iago-mendes requested a review from nilsvu January 24, 2025 08:23
@nilsvu nilsvu merged commit 9111517 into sxs-collaboration:develop Feb 25, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants