Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executable for MC: initialize background #6355

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ffoucart
Copy link
Contributor

Proposed changes

Create base MC executable

Upgrade instructions

None so far

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

@ffoucart
Copy link
Contributor Author

Work in progress -- first commit creates the background fluid and metric variables, EoS and neutrino table.

@ffoucart ffoucart added the in progress Don't review, used for sharing code and getting feedback label Oct 30, 2024
@ffoucart
Copy link
Contributor Author

@nilsdeppe Not sure if we want one big PR for the MC code, or to commit partial work once we have something useful. I'm keeping the work we have done so far (slightly cleaned up for compatibility with other executables) here.

@ffoucart ffoucart force-pushed the MCExecutable branch 2 times, most recently from 41053cd to f533cb9 Compare November 21, 2024 21:11
@ffoucart ffoucart removed the in progress Don't review, used for sharing code and getting feedback label Dec 5, 2024
@ffoucart ffoucart marked this pull request as ready for review December 5, 2024 14:30
@ffoucart ffoucart force-pushed the MCExecutable branch 3 times, most recently from 45d1b93 to 84ed5be Compare December 6, 2024 16:01
@ffoucart
Copy link
Contributor Author

ffoucart commented Dec 6, 2024

Rebased on develop to fix minor conflict with RunEventsAndTriggers (template change, option renamed)

@ffoucart ffoucart force-pushed the MCExecutable branch 2 times, most recently from eb41b51 to 9a144ff Compare December 6, 2024 19:46
This was referenced Dec 10, 2024
@ffoucart
Copy link
Contributor Author

Rebased to make dependent on #6424 . The first commit is now from that PR, the second commit creates the executable; the final part to make it work with input files is in #6403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant