Feature 1338: Suche anpassen #1401
Conversation
|
Some things I have found while testing, before looking at any code:
|
| </ga-search> | ||
|
|
||
| <span class="icon is-close" @click="${this.clear}"></span> | ||
| <span class="icon is-search" @click="${this.toggleActive}"></span> |
There was a problem hiding this comment.
what exactly is the desired behavior on this? When i click the search icon, the result list just flickers
There was a problem hiding this comment.
This is for mobile only, where the search is only visible after clicking the search icon. On desktop, it should just focus the search input. Does something else happen for you (e.g. flickering)? I was not able to reproduce it as of yet.
There was a problem hiding this comment.
Maybe flickering is the wrong word, but when it is in focus already and i click it again, the results quickly disappear (while hodling the mouse) and then reappear. BUt this might just be browser behavior
| const target = this.findActiveResult(); | ||
| if (target != null) { | ||
| const [item, _element] = target; | ||
| this.selectItem(item, {keepFocus: true}); |
There was a problem hiding this comment.
i dont think we want to select the items on arrow keys, but only on click and enter. You can temporarily add the layers as preview, but they should not be added as permanent layers (see general comment)
daniel-va
force-pushed
the
feature/viewer-1338-suche-anpassen
branch
from
c122c91 to
2ae8b39
Compare
|
| @@ -333,6 +338,7 @@ export class SearchInput extends LitElementI18n { | |||
| const child = results.children[i]; | |||
| if (child.ariaSelected === 'true') { | |||
| const item = this.resultItems[i]; | |||
| console.log(item, child); | |||
| this.classList.add('is-active'); | ||
| } else { | ||
| this.classList.remove('is-active'); | ||
| console.log(changedProperties); |
| <ul ${ref(this.resultsRef)}></ul> | ||
| </ga-search> | ||
|
|
||
| <span class="icon is-close" @click="${this.clear}"></span> |
There was a problem hiding this comment.
this now disappears as soon as i start searching
Edit: this was introduced in faab0bd7
| </ga-search> | ||
|
|
||
| <span class="icon is-close" @click="${this.clear}"></span> | ||
| <span class="icon is-search" @click="${this.toggleActive}"></span> |
There was a problem hiding this comment.
Maybe flickering is the wrong word, but when it is in focus already and i click it again, the results quickly disappear (while hodling the mouse) and then reappear. BUt this might just be browser behavior
| display: none; | ||
| } | ||
|
|
||
| :host:not(.is-active) .icon.is-close { |
There was a problem hiding this comment.
this can be reomved, right?
Resolves #1338.