Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for PHPStan 2.0 #20

Merged
merged 7 commits into from
Oct 10, 2024
Merged

Prepare for PHPStan 2.0 #20

merged 7 commits into from
Oct 10, 2024

Conversation

swissspidy
Copy link
Owner

@swissspidy swissspidy added this to the 1.0.0 milestone Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (ec350f9) to head (be5605d).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #20   +/-   ##
=========================================
  Coverage     83.70%   83.70%           
  Complexity       64       64           
=========================================
  Files             6        6           
  Lines           227      227           
=========================================
  Hits            190      190           
  Misses           37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissspidy
Copy link
Owner Author

Build / Tests (true, lowest, 8.2) (pull_request) fails with Call to undefined method PhpParser\ParserFactory::create().

That job runs tests with code coverage, and phpunit/php-code-coverage uses PhpParser\ParserFactory.

The problem is that the autoloader loads the ParserFactory from the PHPStan Phar (/vendor/phpstan/phpstan/phpstan.phar/vendor/nikic/php-parser), which uses PhpParser v5 now that doesn't have this method anymore.

Explicitly requiring php-parser v5 should solve this

@szepeviktor
Copy link
Contributor

This is the pull request of the year.

@swissspidy swissspidy merged commit cf845a1 into main Oct 10, 2024
34 checks passed
@swissspidy swissspidy deleted the try/phpstan-v2 branch October 10, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants