Some code cleanup #184
Merged
Some code cleanup #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominik-cnx
approved these changes
May 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #184 +/- ##
=============================================
+ Coverage 62.42% 62.80% +0.38%
+ Complexity 417 413 -4
=============================================
Files 35 35
Lines 2685 2659 -26
Branches 307 299 -8
=============================================
- Hits 1676 1670 -6
+ Misses 845 830 -15
+ Partials 164 159 -5 ☔ View full report in Codecov by Sentry. |
hiddenalpha
approved these changes
May 2, 2024
| @@ -9,7 +9,8 @@ | |||
| import static org.awaitility.Awaitility.await; | |||
| import static org.hamcrest.CoreMatchers.equalTo; | |||
| import static org.hamcrest.CoreMatchers.is; | |||
| import static org.junit.Assert.assertThat; | |||
| import static org.hamcrest.MatcherAssert.assertThat; | |||
There was a problem hiding this comment.
- import static org.junit.Assert.assertThat;
+ import static org.hamcrest.MatcherAssert.assertThat;I assume those changes are by intent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.