Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#173 Add limit for StorageExpand feature #183

Merged
merged 3 commits into from
May 2, 2024

Conversation

mcweba
Copy link
Collaborator

@mcweba mcweba commented May 1, 2024

No description provided.

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.65%. Comparing base (4e0bec7) to head (604fa52).
Report is 20 commits behind head on develop.

Files Patch % Lines
.../org/swisspush/reststorage/RestStorageHandler.java 90.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #183      +/-   ##
=============================================
+ Coverage      62.42%   62.65%   +0.23%     
- Complexity       417      422       +5     
=============================================
  Files             35       35              
  Lines           2685     2702      +17     
  Branches         307      310       +3     
=============================================
+ Hits            1676     1693      +17     
  Misses           845      845              
  Partials         164      164              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hiddenalpha hiddenalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this is doing. But looks ok code wise.

@mcweba
Copy link
Collaborator Author

mcweba commented May 2, 2024

I don't understand what this is doing. But looks ok code wise.

When you make a StorageExpand request, you provide a list of sub resource names which have to be expanded. With this feature we add a limit (by configuration and overridable by request-header) of how many sub resources should be accepted. When the limit is exceeded, the request is responded with 413 Payload Too Large

@mcweba mcweba merged commit c8e1083 into develop May 2, 2024
6 checks passed
@mcweba mcweba deleted the feature/issue173_storageExpand_limit branch May 2, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants