-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#173 Add limit for StorageExpand feature #183
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #183 +/- ##
=============================================
+ Coverage 62.42% 62.65% +0.23%
- Complexity 417 422 +5
=============================================
Files 35 35
Lines 2685 2702 +17
Branches 307 310 +3
=============================================
+ Hits 1676 1693 +17
Misses 845 845
Partials 164 164 ☔ View full report in Codecov by Sentry. |
src/main/java/org/swisspush/reststorage/RestStorageHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what this is doing. But looks ok code wise.
When you make a StorageExpand request, you provide a list of sub resource names which have to be expanded. With this feature we add a limit (by configuration and overridable by request-header) of how many sub resources should be accepted. When the limit is exceeded, the request is responded with 413 Payload Too Large |
No description provided.