[SDCISA-13221] K8s: vertx-rest-storage #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thwint
commented
Sep 11, 2023
thwint
commented
- made redis client aware of redis cluster
- made redis client aware of redis cluster
oli-h
reviewed
Sep 13, 2023
| redisOptions.setType(RedisClientType.CLUSTER); | ||
| redisOptions.addConnectionString(createConnectString()); | ||
| } else { | ||
| redisOptions.setConnectionString(createConnectString()); |
There was a problem hiding this comment.
redisOptions.setConnectionString(createConnectString()); is the same for the ifand the else case --> move outside of the if
There was a problem hiding this comment.
One is addConnectionString the other is setConnectionString.
dominik-cnx
approved these changes
Sep 15, 2023
mcweba
approved these changes
Sep 15, 2023
thwint
added a commit
that referenced
this pull request
Sep 18, 2023
* updating poms for branch'release-3.0.18' with non-snapshot versions * updating poms for 3.0.19-SNAPSHOT development * updating develop poms to master versions to avoid merge conflicts * Updating develop poms back to pre merge state * [SDCISA-13221] K8s: vertx-rest-storage (#139) - made redis client aware of redis cluster --------- Co-authored-by: runner <runner@fv-az444-271.mvkj0dyzoqtu3fmr4yatzo1xtd.cx.internal.cloudapp.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.