#176 applied feedback

swisspost · Apr 2, 2024 · 4e0bec7 · 4e0bec7
1 parent 30a41f4
commit 4e0bec7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/main/java/org/swisspush/reststorage/redis/RedisMonitor.java b/src/main/java/org/swisspush/reststorage/redis/RedisMonitor.java
@@ -6,10 +6,9 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
+
+import static java.util.Collections.emptyList;
 
 public class RedisMonitor {
     private final Vertx vertx;
@@ -47,11 +46,11 @@ public RedisMonitor(Vertx vertx, RedisProvider redisProvider, String expirableKe
 
     public void start() {
         timer = vertx.setPeriodic(periodMs, timer -> redisProvider.redis().onSuccess(redisAPI -> {
-            redisAPI.info(new ArrayList<>()).onComplete(event -> {
+            redisAPI.info(emptyList()).onComplete(event -> {
                 if (event.succeeded()) {
                     collectMetrics(event.result().toBuffer());
                 } else {
-                    log.warn("Cannot collect INFO from redis");
+                    log.warn("Cannot collect INFO from redis", event.cause());
                 }
             });
 
@@ -60,7 +59,7 @@ public void start() {
                     long value = reply.result().toLong();
                     publisher.publishMetric("expirable", value);
                 } else {
-                    log.warn("Cannot collect zcard from redis for key {}", expirableKey);
+                    log.warn("Cannot collect zcard from redis for key {}", expirableKey, reply.cause());
                 }
             });
 

diff --git a/src/main/java/org/swisspush/reststorage/util/ResourcesUtils.java b/src/main/java/org/swisspush/reststorage/util/ResourcesUtils.java
@@ -38,7 +38,7 @@ public static String loadResource(String resourceName, boolean exceptionWhenNotF
             URL url = Resources.getResource(resourceName);
             return Resources.toString(url, Charsets.UTF_8);
         } catch (Exception e) {
-            log.error("Error loading resource '"+resourceName+"'", e);
+            log.error("Error loading resource '{}'", resourceName, e);
             if(exceptionWhenNotFound){
                 throw new RuntimeException("Error loading required resource '"+resourceName+"'");
             }