Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report errors through eventBus as intended #212

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Report errors through eventBus as intended #212

wants to merge 1 commit into from

Conversation

hiddenalpha
Copy link
Member

No description provided.

mcweba
mcweba requested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@mcweba mcweba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to have a good look how these changes affect the behavior. Also check/adopt the unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcweba mcweba mcweba requested changes

@ljucam ljucam Awaiting requested review from ljucam

@Swisspusher Swisspusher Awaiting requested review from Swisspusher

@dominik-cnx dominik-cnx Awaiting requested review from dominik-cnx

@linovifian linovifian Awaiting requested review from linovifian

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiddenalpha @mcweba