fix(styles): remove deprecated accent colors(#3227) #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
October 8, 2024 14:16
…nt-color` behavior
…om background.module.scss
2 tasks
🦋 Changeset detectedLatest commit: cf02bfe The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
gfellerph
requested changes
Oct 10, 2024
.changeset/red-cobras-cry.md
Outdated
| '@swisspost/design-system-styles': patch | ||
| --- | ||
|
|
||
| Removed deprecated accent colors and updated all relevant components, documentation, and utilities. |
There was a problem hiding this comment.
Suggested change
| Removed deprecated accent colors and updated all relevant components, documentation, and utilities. | |
| Removed deprecated accent colors (nightblue, petrol, coral, olive, purple, aubergine and their light variations) and updated all relevant components, documentation, and utilities. |
packages/documentation/src/stories/components/topic-teaser/topic-teaser.snapshot.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/components/topic-teaser/topic-teaser.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/components/topic-teaser/topic-teaser.stories.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The BackgroundStories.TranslucentBackgrounds story implements bg-aubergine as well. Could you change this to bg-dark there?
Comment on lines
-286
to
-290
| // Color variants | ||
| @each $name, $color in color.$accent-colors { | ||
| @include button-mx.button-color-variant($name, $color); | ||
| } | ||
|
|
There was a problem hiding this comment.
Removing this reduces so much CSS output. Very satisfying.
gfellerph
requested changes
Oct 10, 2024
.changeset/red-cobras-cry.md
Outdated
Comment on lines
2
to
4
| '@swisspost/design-system-styles-primeng-workspace': patch | ||
| '@swisspost/design-system-documentation': patch | ||
| '@swisspost/design-system-styles': patch |
There was a problem hiding this comment.
Suggested change
| '@swisspost/design-system-styles-primeng-workspace': patch | |
| '@swisspost/design-system-documentation': patch | |
| '@swisspost/design-system-styles': patch | |
| '@swisspost/design-system-styles-primeng-workspace': patch | |
| '@swisspost/design-system-documentation': patch | |
| '@swisspost/design-system-styles': major |
…tion Co-authored-by: Philipp Gfeller <[email protected]>
Co-authored-by: Philipp Gfeller <[email protected]>
Co-authored-by: Philipp Gfeller <[email protected]>
…://github.com/swisspost/design-system into refactor/3227-remove-deprecated-accent-colors
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.