Bring the features around health checks and metrics to the master and the metrics also #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing readiness and liveness probes.
… endpoints. Enabled in the default profile the kubernertes specific endpoints and removed all the other exposed endpoints.
…eing exposed correctly
staffoleo
force-pushed
the
feature/metrics
branch
from
451c5e7
to
7e1dbd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we bring this branch to the master, that contains the latest changes on the healthchecks and the metrics.
From here we can then close the loop and progress with the rest of the build, because we need a version of the Mag with the latest features so that we can test with Kube and then check the availability of the Prometheus metrics.