Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to common api conventions #25

Merged
merged 87 commits into from
Jun 3, 2024
Merged

Adapt to common api conventions #25

merged 87 commits into from
Jun 3, 2024

Conversation

msacrea
Copy link
Contributor

@msacrea msacrea commented Jun 3, 2024

  • Added pensions statement object pensionStatementBasic
  • Introducing new endpoint for compact JSON of pensionStatementBasic for QR code wrapping
  • Adding employer object to insuredPerson
  • Adding object pensionProvider
  • Extending interestRates object to also include rates for purchase calculations
  • Improving structure of riskBenefits regarding lump sum benefits
  • Merging policies.yaml, purchases.yaml and transactions.yaml into pension.yaml
  • Adding example values
  • Adopted new SFTI naming convention
  • Migrating from OpenAPI specification v3.0.1 to v3.1.0

msacrea and others added 30 commits October 3, 2023 14:26
@msacrea
Merge pull request #3 from swissfintechinnovations/main
7245bb9 
Updated readme.md
@msacrea
Add files via upload
02c1d3b
@msacrea
Linting: Adding and removing spaces
982ecb1
@msacrea
Linting: Fixing spaces & quotes
1a1649b
@msacrea
Linting: More quotes.
b03be42
@msacrea
Linting: Even more quotes.
04b46ea
@msacrea
Linting: Spaces
2597da3
@msacrea
Linting: Single quotes instead of double
24c3448
@msacrea
Linting: Removing braces
61843da
@msacrea
Linting: Revert last change.
d4be37a
@msacrea
Adding first version of remaining yaml files.
6c0f298
@msacrea
Linting consentAPI
a1e44f2
@msacrea
Linting consentAPI
f6f057b
@msacrea
EOL character and flow mapping in directoryAPI
aaa12cf
@dkoeni
format specs
35cf465
@dkoeni
fix indentiation issues
dd4cad0
@msacrea
Updating contact and documentation pointers.
12ccbdf 
Migrating to Apache license 2.0.
@msacrea
Fix quotes according to linthing.
0450e76
@msacrea
Fixing traling spaces linting.
888a62a
@msacrea
Merge branch 'adapt-to-common-api-conventions' of https://github.com/…
783e7b2 
…swissfintechinnovations/ca-pension into adapt-to-common-api-conventions
@msacrea
Schemas converted to camelCase, common data model introduced and secu…
b5d0544 
…rity definitions moved.
@msacrea
Suggested fix for issue 17 - add homeOwnershipWithdrawal field
ccb60c8
@msacrea
Suggested fix for issue 16 - add maxPurchaseAmount field
44f2981
@msacrea
Suggested fix for issue 14 - add employer object to insuredPerson
6c7f425
@msacrea
Suggested fix for issue 18 - add pensionProvider field to policy schema
54759c1
@msacrea
Suggested fix for issue 19 - renaming interestRateEnveloping to inter…
04cb5b0 
…estRateProjectionEnveloping for clarity
@msacrea
Suggested fix for issue 20 - split lumpSumDeathBenefit into two disti…
571333f 
…nct fields in riskBenefits schema
@msacrea
Draft of pensionStatementSimple extension
217128b
@msacrea
Format fixes of new objects
9187e4c
@micmuell
Update policiesAPI.yaml
61912f3 
added pensionProvider as referenced object in policy and pensionStatementSimple
msacrea and others added 26 commits May 7, 2024 17:08
@msacrea
Adapting directoryAPI.yaml to SFTI naming convention part II.
5eecf4c
@msacrea
Adapting pensionAPI.yaml to SFTI naming convention part II - paramete…
8f2933a 
…r order and descriptions.
@msacrea
Adapting pensionAPI.yaml to SFTI naming convention part II - PascalCase
0379ede
@msacrea
Migrating from OpenAPI 3.0.1 to 3.1.0
9895417
@msacrea
Fixing YAML Compliance issues
74f0879
@msacrea
Adapting consentAPI.yaml to updated yaml linter.
9f47333
@msacrea
Adapting directoryAPI.yaml to latest openAPI linter.
d845ff5
@msacrea
Adapting pensionAPI.yaml to latest changes in OpenAPI linter.
b0c8baa
@msacrea
Adapting pensionAPI.yaml to latest OpenAPI linter.
3c6f31b
@msacrea
Group simulations in API structure.
9b871b5
@msacrea
Adding pension plan ID to pension plan schema.
b7277e3
@msacrea
Adding endpoint to fetch pension statement(s) data of an insured person.
14cba29
@msacrea
Moving get statement PDF ressource from policies to statements path.
971424d
@msacrea
Changing retirement age unit from year to month.
d4ba457
@msacrea
Updating main API descriptions to reflect the addition of the stateme…
db7125b 
…nt object.
@msacrea
Forcing exact matches for all regular expressions.
05aff01
@msacrea
Removing cause fromIllness and fromAccident from RiskBenefits.
b77cbee
@msacrea
Extending InterestRates object to also include rates for purchase cal…
415eab2 
…culations.
@msacrea
Introducing new endpoint for compact json for qr code.
1f94bcd
@msacrea
Fixing new endpoint to follow kebab-case.
79d3a23
@msacrea
Fixing error in array declaration.
21439be
@msacrea
Aligning structure of statement-for-qr-code with PensionStatementBasic
63fe003
@msacrea
Updating servers url
ca5f968
@dkoeni
update openAPI action reference
cd20d53
@msacrea
Fixing required definition in nested objects.
de62d33
@msacrea
Merge branch 'adapt-to-common-api-conventions' of https://github.com/…
6db5260 
…swissfintechinnovations/ca-pension into adapt-to-common-api-conventions
@msacrea msacrea requested a review from a team as a code owner June 3, 2024 12:44
dkoeni
dkoeni approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@dkoeni dkoeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@msacrea msacrea merged commit ca30117 into main Jun 3, 2024
8 checks passed
@msacrea msacrea deleted the adapt-to-common-api-conventions branch June 3, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoeni dkoeni dkoeni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msacrea @dkoeni @micmuell