Check the output of wasm in dev subcommand test #473
Merged
+73
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omochi
commented
May 25, 2024
| do { | ||
| try openInSystemBrowser(url: localURL) | ||
| } catch { | ||
| terminal.write("open browser failed: \(error)", inColor: .red) |
omochi
commented
May 25, 2024
| @@ -105,8 +117,8 @@ public actor Server { | |||
|
|
|||
| private var serverChannel: (any Channel)! | |||
|
|
|||
| /// Local URL of this server, `https://128.0.0.1:8080/` by default. | |||
| private let localURL: String | |||
| /// Local URL of this server, `https://127.0.0.1:8080/` by default. | |||
omochi
commented
May 25, 2024
| /// Local URL of this server, `https://128.0.0.1:8080/` by default. | ||
| private let localURL: String | ||
| /// Local URL of this server, `https://127.0.0.1:8080/` by default. | ||
| private let localURL: URL |
omochi
commented
May 25, 2024
| /// - Returns: true if launching command returns successfully. | ||
| @discardableResult | ||
| public func openInSystemBrowser(url: String) -> Bool { | ||
| public func openInSystemBrowser(url: URL) throws { |
There was a problem hiding this comment.
Stringを受け取ってBoolを返していましたが、
URLを受け取って失敗したら例外を投げるようにします。
引数については型を活用します。
エラーについてですが、例外の方が情報が多いです。
おそらく元々の実装はブラウザオープンに失敗しても動作を止めないことを想定していますが、
それは関数呼び出し側の都合で、必要ならcatchすれば良いです。
omochi
commented
May 25, 2024
| @@ -27,7 +27,7 @@ final class WebDriverClientTests: XCTestCase { | |||
| let client = try await WebDriverClient.newSession( | |||
| endpoint: checkRemoteURL(), httpClient: .shared | |||
| ) | |||
| try await client.goto(url: "https://example.com") | |||
| try await client.goto(url: URL(string: "https://github.com/swiftwasm/carton")!) | |||
There was a problem hiding this comment.
一応自分たちが管理してるURLの方が良いと思います。
There was a problem hiding this comment.
The example.com is managed by ICANN. It should be more reliable than GitHub IMO.
| @@ -84,6 +102,16 @@ final class FrontendDevServerTests: XCTestCase { | |||
| let expected = try String(contentsOf: resourcesDir.appending(component: name).asURL) | |||
| XCTAssertEqual(styleCss, expected) | |||
| } | |||
|
|
|||
| try openInSystemBrowser(url: host) | |||
There was a problem hiding this comment.
I don't think open families work on CI. We should use WebDriver or something like headless solutions.
There was a problem hiding this comment.
そうですね。
$ carton test で使われている実装を再利用するようにコードを組んでみます。
omochi
changed the title
omochi
changed the title
kateinoigakukun
approved these changes
May 28, 2024
kateinoigakukun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev serverのテストではコンテンツの配送はテストされていたが、
それをブラウザ開いたらちゃんと動くかどうかは全くテストされていなかった。
dev serverがwasmから受け取った出力をコンソールに出すので、
frontendを起動するテスト側で出力を監視する。
Linux では xdg-open となってるけど CI はうまくいくんだろうか？#474 の成果を使って、
WebDriverを利用してテストする