Add granular configuration for retrying wait time in test #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omochi
commented
May 22, 2024
| var attempt = 0 | ||
| while true { | ||
| try await Task.sleep(for: delay) | ||
|
|
There was a problem hiding this comment.
sleepの場所を組み替えて、
最初と、リトライ時の2つに分けます。
omochi
commented
May 22, 2024
| @@ -41,12 +41,16 @@ final class FrontendDevServerTests: XCTestCase { | |||
| defer { | |||
| devServer.signal(SIGINT) | |||
| } | |||
| try await Task.sleep(for: .seconds(3)) | |||
There was a problem hiding this comment.
最初に3秒まつ処理を withRetry でやります。
kateinoigakukun
changed the title
kateinoigakukun
changed the title
kateinoigakukun
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以下でCIがこけました
#469 (comment)
おそらくタイミング問題で、サーバが立ち上がっていなかっただけなので、
待ってからリトライすれば直ります。
ここで、最初の待ち時間は短くして、
失敗しとの待ち時間は長くしたいです。
そこで既存の
withRetryを改善して指定できるようにします。