use browser exception handling

swiftwasm · May 24, 2024 · 6833478 · 6833478
1 parent dc4ac45
commit 6833478
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 16 deletions.
diff --git a/Sources/CartonKit/Server/StaticArchive.swift b/Sources/CartonKit/Server/StaticArchive.swift
diff --git a/Tests/Fixtures/SandboxApp/Sources/app/main.swift b/Tests/Fixtures/SandboxApp/Sources/app/main.swift
@@ -17,7 +17,7 @@ func fputs(_ string: String, file: FILEPointer) {
 fputs("hello stdout\n", file: stdout)
 fputs("hello stderr\n", file: stderr)
 
-//fatalError("hello fatalError")
+fatalError("hello fatalError")
 
 let document = JSObject.global.document
 

diff --git a/entrypoint/bundle.ts b/entrypoint/bundle.ts
@@ -45,16 +45,8 @@ const startWasiTask = async () => {
   await wasmRunner.run(wasmBytes);
 };
 
-function handleError(e: any) {
-  console.error(e);
-}
-
 async function main(): Promise<void> {
-  try {
-    await startWasiTask();
-  } catch (e) {
-    handleError(e);
-  }
+  await startWasiTask();
 }
 
 main();
diff --git a/entrypoint/dev.ts b/entrypoint/dev.ts
@@ -60,8 +60,6 @@ const startWasiTask = async () => {
 };
 
 function handleError(e: any) {
-  console.error(e);
-
   if (e instanceof Error) {
     const stack = e.stack;
     if (stack != null) {
@@ -78,16 +76,15 @@ function handleError(e: any) {
 async function main(): Promise<void> {
   try {
     window.addEventListener("error", (event) => {
-      event.preventDefault();
       handleError(event.error);
     });
     window.addEventListener("unhandledrejection", (event) => {
-      event.preventDefault();
       handleError(event.reason);
     });
     await startWasiTask();
   } catch (e) {
     handleError(e);
+    throw e;
   }
 }