Lower deployment target to macOS 10.13 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kabiroberai
commented
Apr 30, 2024
Sources/WasmKit/ModuleParser.swift
Outdated
| @@ -126,7 +125,8 @@ func parseModule<Stream: ByteStream>(stream: Stream, features: WasmFeatureSet = | |||
| memoryTypes: module.memories.map { $0.type }, | |||
| tables: module.tables | |||
| ) | |||
| let enableAssertDefault = _slowPath(getenv("WASMKIT_ENABLE_ASSERT") != nil) | |||
| #warning("Get env without foundation") | |||
| let enableAssertDefault = false // _slowPath(getenv("WASMKIT_ENABLE_ASSERT") != nil) | |||
There was a problem hiding this comment.
@kateinoigakukun any suggestions for working around this? This is the only spot where I haven't been able to find a solution yet that doesn't involve Foundation — afaict SwiftSystem doesn't have support for reading the environment.
|
For Foundation dependency, I cleaned up a bit and picked a part of your changes here #92 |
# Conflicts: # Package.swift # Sources/CLI/Run/Run.swift # Sources/WASI/Platform/File.swift # Sources/WASI/WASI.swift # Sources/WasmKit/Execution/Runtime/Profiler.swift # Sources/WasmKit/ModuleParser.swift # Sources/WasmParser/CMakeLists.txt # Sources/WasmParser/Stream/FileHandleStream.swift
kabiroberai
changed the title
|
@kateinoigakukun I updated this PR to just lower the deployment target, should be ready for review! Aside: can't seem to cancel stale CI jobs, feel free to do that for the intermediate commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't tested everything yet but so far it builds. See:
https://github.com/apple/swift/pull/73031/files#r1581621839
https://github.com/apple/swift/pull/73031/files#r1581597854