Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract ExecutionState from the Runtime type #67

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Extract ExecutionState from the Runtime type #67

merged 1 commit into from
Nov 15, 2023

Conversation

MaxDesiatov
Copy link
Collaborator

Runtime no longer manages the execution state of a guest program. Separating the execution state makes it easier to have a fresh stack for each invocation of an exported function. Also it's now safe to provide a way to access Runtime during HostFunction execution since no mutable execution state is exposed.

Additionally, tests were added to verify the new API surface.

@MaxDesiatov MaxDesiatov marked this pull request as draft November 13, 2023 22:10
@MaxDesiatov MaxDesiatov removed the request for review from kateinoigakukun November 13, 2023 22:10
@MaxDesiatov
Copy link
Collaborator Author

MaxDesiatov commented Nov 13, 2023

Marking as a draft until CI issues are resolved in a separate PR.

`Runtime` no longer manages the execution state of a guest program. Separating the execution state makes it easier to have a fresh stack for each invocation of an exported function. Also it's now safe to provide a way to access `Runtime` during `HostFunction` execution since no mutable execution state is exposed.

Additionally, tests were added to verify the new API surface.

Co-authored-by: Yuta Saito <[email protected]>
@MaxDesiatov MaxDesiatov marked this pull request as ready for review November 15, 2023 09:38
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kateinoigakukun kateinoigakukun merged commit a5e045d into swiftwasm:main Nov 15, 2023
6 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/extract-execution-state branch November 15, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants