AST/Sema: Generalize availability fix-its to support custom availability domains #83168
+398
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been replaced by `Decl::isAvailableAsSPI()`. NFC.
It should be preferred over querying the deployment range from the availability domain returned by `ASTContext::getTargetAvailabilityDomain()`. NFC.
Make it easier to debug availability by printing to output streams like `llvm::errs()`. NFC.
Use these queries to replace some duplicated code. Also, move the `attr_inlinable_available.swift` test to the `Availability` sub-directory since the test has more to do with availability checking than it has to do specifically with the `@inlinable` attr.
…omains. Resolves rdar://156118254.
|
@swift-ci please test |
|
Based on top of #83162. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the compiler emits a diagnostic like
there should be a fix-it emitted that suggests adding an
@available(MyFeature)attribute tofoo()and another fix-it that suggests addingif #available(MyFeature) { … }.Resolves rdar://156118254.