[6.2][Concurrency] NonisolatedNonsendingByDefault: Infer nonisolated(nonsending) on declaration with special special semantics
#83165
+94
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sending)` to `withoutActuallyEscaping` `withoutActuallyEscaping` is type-checked in a special way which means that we need to explicitly inject `nonisolated(nonsending)` isolation when forming a reference to this builtin. (cherry picked from commit 48f4d7b)
…sending)` to `_openExistential` `_openExistential` is type-checked in a special way which means that we need to explicitly inject `nonisolated(nonsending)` isolation when forming a reference to this builtin. (cherry picked from commit 358869f)
|
@swift-ci please test |
DougGregor
approved these changes
Jul 18, 2025
DougGregor
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
We missed a few cases of inference of
nonisolated(nonsending)due to the fact that the types forwithoutActuallyEscapingand_openExistentialreferences are formed during solving and require special handling.Resolves: rdar://156115100
Main Branch PR: [Concurrency] NonisolatedNonsendingByDefault: Infer
nonisolated(nonsending)on declaration with special special semantics #83164Risk: Low. These changes are narrow to two builtin functions with special reference semantics and guarded by
NonisolatedNonsendingByDefault.Reviewed By: @DougGregor
Testing: Added new test-cases.