Skip to content

Basic: Adjust condition for include after macro removal in upstream LLVM #81819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented May 28, 2025

HAVE_SYS_RESOURCE_H was removed in llvm/llvm-project#123288, so this header is no longer included at this particular location on rebranch, which breaks the Linux build, where it is not transitively included either.

Use the same condition as in the use site (getChildrenMaxResidentSetSize) instead.

Also, don't wrap HAVE_GETRUSAGE in defined() in case it does get defined to 0.

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

`HAVE_SYS_RESOURCE_H` was removed in
llvm/llvm-project#123288, so this header is no
longer included at this particular location on rebranch, which breaks
the Linux build, where it is not transitively included either.

Use the same condition as in the use site
(`getChildrenMaxResidentSetSize`) instead.

Also, don't wrap `HAVE_GETRUSAGE` in `defined()` in case it does get
defined to 0.
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis enabled auto-merge May 28, 2025 23:07
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test Linux

@AnthonyLatsis AnthonyLatsis merged commit 9753d23 into swiftlang:main May 29, 2025
3 checks passed
@AnthonyLatsis AnthonyLatsis deleted the neotrygon branch May 29, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants