Skip to content

[6.2][Concurrency] Fix races/overflows in TaskGroup implementation. #81815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

[6.2][Concurrency] Fix races/overflows in TaskGroup implementation. #81815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions stdlib/public/Concurrency/DiscardingTaskGroup.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public func withDiscardingTaskGroup<GroupResult>(
discardResults: true
)

let _group = Builtin.createTaskGroupWithFlags(flags, GroupResult.self)
let _group = Builtin.createTaskGroupWithFlags(flags, Void.self)
var group = DiscardingTaskGroup(group: _group)
defer { Builtin.destroyTaskGroup(_group) }

Expand Down Expand Up @@ -108,7 +108,7 @@ public func _unsafeInheritExecutor_withDiscardingTaskGroup<GroupResult>(
discardResults: true
)

let _group = Builtin.createTaskGroupWithFlags(flags, GroupResult.self)
let _group = Builtin.createTaskGroupWithFlags(flags, Void.self)
var group = DiscardingTaskGroup(group: _group)
defer { Builtin.destroyTaskGroup(_group) }

Expand Down Expand Up @@ -347,7 +347,7 @@ public func withThrowingDiscardingTaskGroup<GroupResult>(
discardResults: true
)

let _group = Builtin.createTaskGroupWithFlags(flags, GroupResult.self)
let _group = Builtin.createTaskGroupWithFlags(flags, Void.self)
var group = ThrowingDiscardingTaskGroup<Error>(group: _group)
defer { Builtin.destroyTaskGroup(_group) }

Expand Down Expand Up @@ -378,7 +378,7 @@ public func _unsafeInheritExecutor_withThrowingDiscardingTaskGroup<GroupResult>(
discardResults: true
)

let _group = Builtin.createTaskGroupWithFlags(flags, GroupResult.self)
let _group = Builtin.createTaskGroupWithFlags(flags, Void.self)
var group = ThrowingDiscardingTaskGroup<Error>(group: _group)
defer { Builtin.destroyTaskGroup(_group) }

Expand Down
Loading