Swift SIL: Fix argument conventions for functions which have both, a direct and indirect result#81806
Merged
eeckstein merged 1 commit intoswiftlang:mainfrom May 30, 2025
Merged
Conversation
…direct and indirect result. The function convention for the first argument is not identified as indirect-out. This lets alias analysis assume that the memory pointed to by argument 0 cannot be written by the called function. The problem is that subscripting a LazyFilterCollection (with the base index, e.g. `Int`) does not work as expected, because it returns the nth element of the base collection! The fix is to implement the subscript "manually". Fixes a mis-compile. rdar://152160748
Contributor
Author
|
@swift-ci test |
atrick
approved these changes
May 28, 2025
Contributor
atrick
left a comment
atrick
left a comment
There was a problem hiding this comment.
Thanks for tracking this down.
Contributor
Author
|
@swift-ci smoke test macos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function convention for the first argument is not identified as indirect-out. This lets alias analysis assume that the memory pointed to by argument 0 cannot be written by the called function.
The problem is that subscripting a LazyFilterCollection (with the base index, e.g.
Int) does not work as expected, because it returns the nth element of the base collection! The fix is to implement the subscript "manually".Fixes a mis-compile.
rdar://152160748