[6.2] SILGen: Emit property descriptors for conditionally Copyable and Escapable types. #81796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pable types. Key paths can't reference non-escapable or non-copyable storage declarations, so we don't need to refer to them resiliently, and can elide their property descriptors. However, declarations may still be conditionally Copyable and Escapable, and if so, then they still need a property descriptor for resilient key path references. When a property or subscript can be used in a context where it is fully Copyable and Escapable, emit the property descriptor in a generic environment constrained by the necessary conditional constraints. Fixes rdar://151628396.
|
@swift-ci Please test |
slavapestov
approved these changes
May 28, 2025
tbkka
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes an ABI oversight where we would neglect to emit key path property descriptors for declarations that are conditionally
Copyable, while also suppressing the attempt to emit key path property descriptors for types that are notEscapable, sinceKeyPathrequiresEscapabletypes, and our codegen would trigger unwanted lifetime errors in implicitly-generated key path thunks.Scope: Bug fix.
Issue: rdar://151628396.
Original PR: #81617
Risk: Low. Changes the conditions under which key path property descriptors are emitted, but doesn't affect their code generation or behavior.
Testing: Swift CI, test case from bug report
Reviewer: @slavapestov