Skip to content

[6.2] build.ps1 updates for new SwiftASN1 dependency #81443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

[6.2] build.ps1 updates for new SwiftASN1 dependency #81443

merged 2 commits into from
May 12, 2025

Conversation

dschaefer2
Copy link
Member

@dschaefer2 dschaefer2 commented May 12, 2025 •
edited by bnbarham
Loading

dschaefer2 added 2 commits May 12, 2025 10:07
@dschaefer2
Add SwiftASN1 to sourcekit-lsp dependencies for Windows.
8c5fd21 
Updates the build.ps1 script to add the SwiftASN1 package support
to it's CMake build. This was caused by this dependency being added
to a module in SwiftPM that sourcekit-lsp imports.
@dschaefer2
Add ASN1 module to SourceKit-LSP Test
e41e191 
Super surprised to see the build for swift test hardcoded in
the build.ps1 script instead of in the sourcekit-lsp repo.
At any rate, looks like I need to add the dependency on ASN1
here too.

This is to support changes in SwiftPM that add the dependency
which translates through to sourcekit-lsp.

swiftlang/swift-package-manager#8610
@dschaefer2 dschaefer2 requested a review from a team as a code owner May 12, 2025 14:14
@dschaefer2
Copy link
Member Author

@swift-ci please test

@bnbarham bnbarham changed the title 6.2 sourcekit asn1 [6.2] build.ps1 updates for new SwiftASN1 dependency May 12, 2025
@dschaefer2 dschaefer2 enabled auto-merge May 12, 2025 16:59
@dschaefer2 dschaefer2 merged commit 4e30d49 into swiftlang:release/6.2 May 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschaefer2 @bnbarham