[Sema] Support additional args in @dynamicMemberLookup subscripts #81148
Conversation
include/swift/AST/Decl.h
Outdated
There was a problem hiding this comment.
DynamicMemberLookupSubscriptEligibility is... a mouthful — but it's the least-inaccurate name I could come up with. Happy to improve this with suggestions!
include/swift/AST/Decl.h
Outdated
There was a problem hiding this comment.
Instead of exposing this enum, I suppose it is also possible to restore isValidDynamicMemberLookupSubscript() et. al., but I do think it's nicer to have a type-safe interface that's harder to typo.
|
@swift-ci please smoke test |
`SubscriptDecl`s may get checked multiple times for eligibility in fulfilling `@dynamicMemberLookup` requirements; since the checks are non-trivial and the result doesn't change, this eligibility can be cached in the decl's `Bits`.
`SubscriptDecl` exposes eligibility for `@dynamicMemberLookup` requirements directly, so the `TypeChecker` interface for these members can be replaced.
Adds support for `SubscriptDecl`s to fulfill `@dynamicMemberLookup` requirements if they have additional arguments after `dynamicMember:` so long as those arguments have default values, or are variadic. This allows exposing values like `#function`, `#fileID`, `#line`, etc. to dynamic member lookup.
Subscripts with `isolated` arguments currently do not pass a compiler assertion about the consistency of the function type w.r.t. isolation. This is because the `ExtInfo` for `SubscriptDecl`s doesn't currently have isolation information applied (though this works in practice); annotating the `ExtInfo` with isolation allows this assertion to pass.
itaiferber
force-pushed
the
additional-dynamicmemberlookup-args
branch
from
725aeab to
5e77bd2
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please build toolchain |
xwu
added
the
swift evolution approved
|
@slavapestov / @hborla / @xedin Now that SE-0484 has been accepted, please don't hesitate to let me know if there's anything I can do to make a review here easier — I know this is a busy time for Apple folks. Hoping the changes here are uncontroversial enough, but happy to adjust with feedback! |
|
I assume that it's probably a bit late to try to get this into Swift 6.2 at this point and that we'll aim for 6.3, but if there's anything I can do to help with this PR, please let me know! |
2 participants
Adds support for satisfying
@dynamicMemberLookuprequirements using subscripts which have arguments followingdynamicMember:so long as they are either variadic or have default arguments. This allows transforming member references intox[dynamicMember:...]calls which can pass in arguments such as#function,#fileID,#line, etc.@dynamicMemberLookupSubscripts swift-evolution#2814Main changes:
SubscriptDecls to satisfy@dynamicMemberLookuprequirements as long asdynamicMember:remains the first explicitly-labeled argument, and all following arguments are eitherisDefaultArgument()orisVariadic()SubscriptDecl.Bits; this was being checked multiple times per decl and it seems prudent to just store the info since we have the bitsExprRewriterto produceArgumentLists for these subscripts by filling inDefaultArgumentExprs as neededThe PR has been split into individual commits for (ideally) ease of review.