Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1][ScanDependency] Swift source module should not have build args for modules #78339

Open
wants to merge 1 commit into
base: release/6.1
Choose a base branch
from
Open

[6.1][ScanDependency] Swift source module should not have build args for modules #78339

wants to merge 1 commit into from
+57 −39

Conversation

cachemeifyoucan
Copy link
Contributor

  • Explanation: When planning for a swift source module, it should not get build commands for its module dependencies. Those dependencies should be planned and added by swift-driver.
  • Scope: This makes build command for the main module unnecessarily long.
  • Issues: rdar://141843125
  • Original PRs: [ScanDependency] Swift source module should not have build args for modules #78331
  • Risk: Low. Not appending certain flags to source module.
  • Testing: Added unit tests.
  • Reviewers: @artemcm

@cachemeifyoucan
[ScanDependency] Swift source module should not have build args for m…
123892c 
…odules

When planning for a swift source module, it should not get build
commands for its module dependencies. Those dependencies should be
planned and added by swift-driver.

This is another regression from swiftlang#76700 that causes unnecessary increase
of build command-line size.

rdar://141843125
@cachemeifyoucan cachemeifyoucan requested a review from a team as a code owner December 21, 2024 06:51
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@artemcm artemcm requested a review from nkcsgexi December 22, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@nkcsgexi nkcsgexi Awaiting requested review from nkcsgexi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cachemeifyoucan @artemcm