Fixup InMemoryFilesSystemTests to use #expect(throws:) vs withKnownIssue #9481
+35
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `InMemoryFilesSystemTests` were using `withKnownIssue` to validate that the file system was throwing errors when expected. This was polluting the test report with tests that appeared to have known issues, but were actually working as intended. Use `#expect(throws:)` to validate these functions are throwing the appropriate error as expected.
plemarquand
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test |
jakepetroules
approved these changes
Dec 9, 2025
bripeticca
approved these changes
Dec 10, 2025
Contributor
|
@swift-ci please test macOS |
bkhouri
reviewed
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InMemoryFilesSystemTestswere usingwithKnownIssueto validate that the file system was throwing errors when expected. This was polluting the test report with tests that appeared to have known issues, but were actually working as intended.Use
#expect(throws:)to validate these functions are throwing the appropriate error as expected.