Refactor ThreadSafeBox to use non-optional type #9477
+1,136
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test |
Change the underlying storage type from `Value?` to storing `Value`, with optional-specific operations moved to constrained extensions. This improves type safety by eliminating unnecessary optionality for non-optional types. This stronger type constraint makes it more difficult for the struct to be misused. For instance in the current implementation the extension method `increment()` will fail to increment if the user forgot to initialize the `ThreadSafeBox` with a value. Now a value must be set initially before increment is called. Also this patch prevents a race condition in the `memoize` methods where the call to the memoized `body` was not guarded by a lock which allowed multiple threads to call memoize at once and produce inconsistent results. Finally, fix the subscript setter so it works properly with `structs`, as the `if var value` and then value set will set the value on a copy, not on the `self.underlying` struct. Now that the type is no longer optional this unwrapping isn't necessary and we can set directly on the value.
plemarquand
force-pushed
the
thread-safe-box-refinements
branch
from
71c68f2 to
516b83a
Compare
Contributor
Author
|
@swift-ci test |
jakepetroules
approved these changes
Dec 10, 2025
Contributor
Author
|
@swift-ci test macOS Platform |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the underlying storage type from
Value?to storingValue, with optional-specific operations moved to constrained extensions.This improves type safety by eliminating unnecessary optionality for non-optional types.
This stronger type constraint makes it more difficult for the struct to be misused. For instance in the current implementation the extension method
increment()will fail to increment if the user forgot to initialize theThreadSafeBoxwith a value. Now a value must be set initially before increment is called.Also this patch prevents a race condition in the
memoizemethods where the call to the memoizedbodywas not guarded by a lock which allowed multiple threads to call memoize at once and produce inconsistent results.Finally, fix the subscript setter so it works properly with
structs, as theif var valueand then value set will set the value on a copy, not on theself.underlyingstruct. Now that the type is no longer optional this unwrapping isn't necessary and we can set directly on the value.