Skip to content

6.2: Use WasmKit by default for Wasm triples in toolsets #8692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented May 19, 2025

Cherry-pick of #8668, merged as 02fe923

Explanation: As WasmKit is included in recent development snapshots of the swift.org toolchain, we should select it as a default debugger and test runner when a Wasm triple is selected. User toolsets can still override it if needed through toolset merging algorithm described in SE-0387.

This allows swift run and swift test to delegate to WasmKit when cross-compiling for any Wasm triple.

Scope: Limited to cross-compilation.
Risk: Low due to limited scope and added test coverage.
Testing: Add new automated test cases, manual testing with Wasm products.
Issue: rdar://150382758
Reviewer: @kateinoigakukun @jakepetroules

As [WasmKit](https://github.com/swiftwasm/WasmKit) is included in recent development snapshots of the swift.org toolchain, we should select it as a default debugger and test runner when a Wasm triple is selected. User toolsets can still override it if needed through toolset merging algorithm described in [SE-0387](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0387-cross-compilation-destinations.md).

This allows `swift run` and `swift test` to delegate to WasmKit when cross-compiling for any Wasm triple.

rdar://150382758
# Conflicts:
#	Tests/PackageModelTests/SwiftSDKBundleTests.swift
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@MaxDesiatov
Copy link
Contributor Author

swiftlang/sourcekit-lsp#2162
@swift-ci test linux

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

swiftlang/sourcekit-lsp#2162
@swift-ci test linux

@bnbarham
Copy link
Contributor

@bnbarham
Copy link
Contributor

swiftlang/sourcekit-lsp#2162

@swift-ci test macOS platform

@dschaefer2 dschaefer2 merged commit 5e4b608 into release/6.2 May 22, 2025
6 checks passed
@dschaefer2 dschaefer2 deleted the maxd/wasmkit-path-6.2 branch May 22, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants