[6.0] Upgrade SwiftFoundationICU to version 74#809
Merged
iCharlesHu merged 1 commit intoswiftlang:release/6.0from Aug 5, 2024
Merged
[6.0] Upgrade SwiftFoundationICU to version 74#809iCharlesHu merged 1 commit intoswiftlang:release/6.0from
iCharlesHu merged 1 commit intoswiftlang:release/6.0from
Conversation
Contributor
Author
|
@swift-ci please test |
Contributor
|
Can we find a way to run swift-corelibs-foundation's unit tests on top of this? Even locally, just to verify. |
Contributor
Author
Yes! We've been running toolchain tests here: swiftlang/swift-corelibs-foundation#5040 Both Windows and Linux passes |
itingliu
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation: Upgrade SwiftFoundationICU dependency 74, which aligns with macOS Sonoma
Scope: update Package.swift to fetch the new ICU
Original PR: #802
Risk: minimum. Only Package.swift and test files are affected
Testing: Testing done via local SwiftPM tests and swift-ci tests to ensure the new ICU works with SwiftFoundation
Reviewer: @jmschonfeld